diff: add unit tests for copy tracking in the git backend #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipMetzger
approved these changes
Jul 15, 2024
martinvonz
reviewed
Jul 17, 2024
There was a problem hiding this comment.
nit: Since this is specific to the git backend, I think this should go in test_git_backend.rs. Could you move it there?
| } | ||
|
|
||
| #[test] | ||
| fn test_git_detection() { |
There was a problem hiding this comment.
It would be good to have tests with more than one file in each commit to show that we detect the right copies. It would also be good to have tests where the contents don't match exactly.
There was a problem hiding this comment.
I thought about this, but at some point we are just testing the implementation of gix. Given that all logic for quality of comparison resides there, I would rather not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md